Skeleton updates #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the package up to date with skeleton v0.2.0
Some notes/todos, probably for different PRs:
LinearAlgebra.qr(::AbstractArray, ::Tuple, ::Tuple, ::Tuple)
is both piracy and a large (40+) source of ambiguities, because LinearAlgebra tends to specialize according toqr(::StructuredArray, args...)
. Because I'm not so familiar with what this signature is specifically used for, I was wondering if it would be possible to only define this in terms ofLinearAlgebra.qr(::AbstractArray, ::BlockPermutation)
and do the other dispatch manually.