[Documentation] Pairwise salt

[peppelinux]

the salt involved in subject must be documented, otherwise it's hard to go in production with multiple workers that have random salt in each of their instances

see oidcop.session.manager.PairWiseID and other IDs

[rohe]

Salt is defined as a dump parameter in SessionManager. It should take care of this.
May have to add a test to verify it.

[peppelinux]

it seems to me that's not actually aware of it

      },
      "session_key": {
        "filename": f"{OIDC_JWKS_PRIVATE_PATH}/session_jwk.json",
        "type": "OCT",
        "use": "sig"
      },
      "sub_func": {
        "public": {
          "class": "oidcop.session.manager.PublicID",
          "kwargs": {
            "salt": "sdfsdfdsf"
          }
        },
        "pairwise": {
          "class": "oidcop.session.manager.PairWiseID",
          "kwargs": {
            "salt": "sdfsdfsdf"
          }
        }
     },

the dump shows random salt instead of the defined one

[peppelinux]

and more, it happens, somethimes, that session manager dump doesn't have salt and key correctly valued

...


 'id_token'], 'max_usage': 1}, 'used': 0, 'claims': {}, 'id': '5c0b3dc9b71b11eb83cf558fb4b9e83d', 'name': 'AuthorizationCode', 'resources': [], 'scope': [], 'type': 'authorization_code', 'value': 'Z0FBQUFBQmdvbnc2bF ... Gc4bEhlOGtOUlFXSlZSND0='}}], 'token_map': {'authorization_code': 'oidcop.session.token.AuthorizationCode', 'access_token': 'oidcop.session.token.AccessToken', 'refresh_token': 'oidcop.session.token.RefreshToken', 'id_token': 'oidcop.session.token.IDToken'}}]}, 

'key': '', 'salt': ''}

[rohe]

Ah, now I get it.

Each sub function doesn't have a salt of its own the SessionManager instance has a salt which is then used by all sub function.

[peppelinux]

Ok, how to deal with that?
Do you have something to be coded/refactored in the project or do we have to made some changes in documentation and example configuration?

[rohe]

I think changing documentation and example configuration is what should be done.

[peppelinux]

Put your notes here, I can do the commit or do your commits then I'll updated the pendig PR about the Docs

[rohe]

I don't think there is anything to change in the example/flask_op configuration.
And there is no mentioning of salt in the documentation that I can find.

[peppelinux]

The missing salt was fixed here
#59

This issue wants to do some docs about sub_funcs and salt. Now I see how this salt have been involved in session manager, it's time for documenti It!

[peppelinux]

Closed by #59