This repository was archived by the owner on Jun 23, 2023. It is now read-only.
Don't create a new client session every time #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Completely agree, smarter than before, ok! |
|
But, please, rebase to develop branch! |
peppelinux
approved these changes
Jul 28, 2021
A new client session was created every time create_session was called, this resulted in losing the client subordinates
nsklikas
force-pushed
the
fix-client-session
branch
from
02e621a to
7ca060d
Compare
|
Ow , I didn't notice it was on master... |
rohe
approved these changes
Jul 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new client session was created every time create_session was called, this resulted in losing the client subordinates.
Have you stumbled onto this or am I misusing
create_session?