This repository was archived by the owner on Jun 23, 2023. It is now read-only.
Fix JWT access token lifetime #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
approved these changes
Aug 16, 2021
| self, | ||
| session_id: Optional[str] = "", | ||
| ttype: Optional[str] = "", | ||
| usage_rules: Optional[dict] = None, |
There was a problem hiding this comment.
None or {}?
it's a dict, probably {} Is better
There was a problem hiding this comment.
I've always (well almost) refrained from using mutable values as defaults. So I'd vote for None.
There was a problem hiding this comment.
Yes, a dict for a default value is a bug waiting to happen
There was a problem hiding this comment.
I've always thought about why a variable of one type could take on another type, such as None. But it's a completely cosmetic thing in python, let's move on
rohe
approved these changes
Aug 17, 2021
|
@nsklikas we just have to patch the conflicting files, then merge |
nsklikas
force-pushed
the
feature-jwt-access-lifetime
branch
from
2fc90e6 to
4c4e1e0
Compare
peppelinux
force-pushed
the
develop
branch
2 times, most recently
from
406068c to
78cae68
Compare
peppelinux
approved these changes
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expires_indefined in usage rules was not reflected to the access token when it was a JWT