This repository was archived by the owner on Jun 23, 2023. It is now read-only.
Include oidcendpoint in oidcop #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With new sesssion management and persistent storage handling.
Use create_session from the Authorization endpoint.
peppelinux
approved these changes
Apr 15, 2021
The package now produces information to be placed in cookies. This is information like the name, max-age and the value. Whatever more needs to be put into a cookie is expected to be done by the frontend. The package then also expects to receive cookie information in the same format as it exported.
- Wrong parameter order - not instead of None - need to pick up cookie name somewhere - type in cookie not used anymore - adapted add_cookie in views.py
Replaced oidcendpoint with oidcop where still remaining.
rohe
commented
Apr 26, 2021
… into incl_oidcendpoint
Added ID Token to issued_token.
…e in Configure.create_from_config_file
* feat: added run.sh in flask_op example some dummy code linting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same manner as with oidcservice and OidcRP, oidcendpoint are in this release included in OidcOP.
Ease of maintenance is one reason. Keeping track of 3 packages is easier than keeping track on 4.
And OidcOP didn't contain a lot except for some examples.
While move oidcendpoint into OidcOP more things happened. One was that the new session management system
was included another that the new persistent storage model was applied.
So all and all quite a lot of changes.