This repository was archived by the owner on Jun 23, 2023. It is now read-only.
construct_endpoint_info #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- chore: general refactor - feat: WEAK algorithms makes a warning message in logs this commit addresses #22
peppelinux
commented
May 15, 2021
| _info[attr] = default_val | ||
| elif "signing_alg_values_supported" in attr: | ||
| _info[attr] = assign_algorithms("signing_alg") | ||
| if "none" in _info[attr]: |
There was a problem hiding this comment.
@roland this is the only warning I'd tell you.
In you previour approach only if attr == "token_endpoint_auth_signing_alg_values_supported" the none value has been removed. I didn't understad this condition, so I remove none at every occourrence.
Feel free to revert and explain why that rule is only valid for token_endpoint_auth_signing_alg_values_supported
Closed
rohe
approved these changes
May 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR helped understanding a weakness in the general configuration manager, used to put default capabilities and get it in provider-discovery json response BUT these paramenters doesn't really changed the endpoints behaviour.
With this approach I got several benefits, also did:
this commit addresses #22