This repository was archived by the owner on Jun 23, 2023. It is now read-only.
jwks factory #39
Merged
jwks factory #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: factory creates two different folder even If a private_path was defined in the general configuration - chore: small code refactor with linting
rohe
approved these changes
May 16, 2021
peppelinux
commented
May 16, 2021
| elif _keyd['kid'] == 'token': | ||
| token = _keyd | ||
|
|
||
| if code is not None: |
There was a problem hiding this comment.
@rohe
should it be if not code instead?
if these definitions already have been configured in the general conf, why should we have to overwrite them?
they would be created if those arguments are None and also configuration's key_defs are None.
Do you agree?
If it's the way Give me a sign of this, I'll push a PR for this
There was a problem hiding this comment.
Ok, you've already achieved this here
062dc1d
well done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR now I have a clean base directory.
I configured custom folders where to store private and public files, but oidc-op still creates a private/token_jwks.json as a duplicate of which i configured with the custom private_path.
digging in the code I found what it could be a silly bug, now it's fixed