This repository was archived by the owner on Jun 23, 2023. It is now read-only.
Test 00 fixed and small cleanups #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
commented
May 15, 2021
| "id_token": { | ||
| "class": "oidcop.id_token.IDToken", | ||
| "kwargs": { | ||
| "default_claims": { |
There was a problem hiding this comment.
I still see a disalignment on which variable name we must use.
I found this in op_config and base_claims in test.
I'm using base_claims, no problem to switch to default_claims, just need to decide which one to use and then a final alignment of code and documentation must be done
There was a problem hiding this comment.
Should always be base_claims. I think I went through the code base yesterday and fixed that everywhere.
rohe
approved these changes
May 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: test 00
fix: scope2claims ->
mapis a primitive and must not be overloaded as a variable