Skip to content
This repository was archived by the owner on Jun 23, 2023. It is now read-only.

Conversation

peppelinux
Copy link
Member

@peppelinux peppelinux commented May 18, 2021

  • chore: coverage of user_authn.user increased
  • chore: src/oidcop/token/id_token.py coverage from 86% to 90%

@rohe I made a code cdoverage in a fast and dirty way, this code is questionable, your quick review or commits above this may make object access methods more obvious, which I modestly dug up with the debugger

Actually src/oidcop/user_info/__init__.py is the file that keep the coverage low, covering this will get a better result ... code is similar to our society, improving the conditions of those who are worse off ... :)

@peppelinux peppelinux requested a review from rohe May 18, 2021 11:47
@peppelinux peppelinux mentioned this pull request May 20, 2021
@peppelinux
Copy link
Member Author

Ah, I also added the templates folders that was missing, the flask example didn't worked without these

"authorization_code": "code",
"access_token": "access_token",
"refresh_token": "refresh_token",
"id_token": "id_token"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohe probably I forget this there ... It's not needed

@rohe
Copy link
Collaborator

rohe commented May 20, 2021

I think we should move userpassjinja2 out of the core code and into the example tree.
But we can do that later.

@rohe rohe merged commit 6f32610 into develop May 20, 2021
@rohe rohe deleted the doc2 branch May 20, 2021 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants