This repository was archived by the owner on Jun 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
Consolidated Pull Request for v2.0.0 development #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: session Database init small generalization
…... also called bug!
tests/test_23_oidc_registration_endpoint.py::TestEndpoint::test_register_alg_keys /home/wert/DEV3/OIDC-Project/env/lib/python3.7/site-packages/cryptojwt/utils.py:257: DeprecationWarning: owner is deprecated; use issuer_id
Added OAuth2ClaimsInterface Added ASConfiguration Changed name of tests to make clear if they where oauth2 or oidc based. Made all OAuth2/OIDC based tests use ASConfiguration/OPConfiguration.
rohe
approved these changes
May 24, 2021
This was referenced May 24, 2021
Closed
Mhhh... the last commit in token branch makes problem in unit tests @rohe |
nsklikas
reviewed
May 24, 2021
nsklikas
reviewed
May 24, 2021
nsklikas
reviewed
May 24, 2021
nsklikas
reviewed
May 24, 2021
chore: pick_auth refactor
nsklikas
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
it fixed merge conflicts, and tested all the things that actually seems to works fine.
I did this job to get an idea of how to continue development in view of the v2.0.0 release, without scattering too much branches.
Since it works and I've done the job, I decided to share it anyway.
@nsklikas currently your opinion is important, if you can not do the revision please unlock us with a sign from you, if we continue to disperse on different branches we will then lose further time to combine all the pieces.
Concluding the remaining issues on the 2.0.0 milestone and following a few days of testing and rereading the features and documentation, we would definitively close this phase.
and, not at last, Documentatioooon!!!!