This repository was archived by the owner on Jun 23, 2023. It is now read-only.
Several Cookies improvements #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BREAKAGE: Cookies flags in cookie_handler.make_cookie_content now are lowercased by default, they doesn't being correctly loaded by flask and django .set_cookie * chore: flask_op views _add_cookie generalization * feat: additional cookie_handler parameter called `flags` to configure whatever cookie flag we desire * feat: Cookie default flags SameSite, HttpOnly and Secure set to True by default
rohe
approved these changes
Jun 6, 2021
nsklikas
approved these changes
Jun 7, 2021
|
lgtm |
This was referenced Jun 9, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flagsto configure whatever cookie flag we desireThis PR closes #86
Now flask_op and django_op propely handles cookie with a good security posture, not at least samesite to None and Secure flags, make SSO still working :)
flask_op
django-oidc-op
