Add timezone argument for IntervalTrigger #174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the start_date passed into the
apscheduler.triggers.interval.IntervalTrigger instances is explicitly
using UTC the timezone argument needs to be passed with UTC as a value.
Since apscheduler only supports pytz and not datetime.timezone we pass
in timezone=pytz.utc.
All Submissions:
It is not clear there exists any test harness for the scheduler yet.
The same tests pass before and after this change (there are currently 8 failing on master and the 1.1.1 tag).
The "new" code is not following flake8 yet.