Skip to content

fix(simple-combo): prevent Enter key default behavior when filtering data - 17.2.x #14295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 10, 2024
Merged

fix(simple-combo): prevent Enter key default behavior when filtering data - 17.2.x #14295

merged 6 commits into from
Jun 10, 2024

Conversation

@RivaIvanova
Copy link
Member

Closes #14198

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@RivaIvanova RivaIvanova linked an issue May 30, 2024 that may be closed by this pull request
Simple Combo cannot submit form via ngSubmit #14198
Closed
@Zneeky Zneeky added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 10, 2024
@ChronosSF ChronosSF merged commit 36e1d4c into 17.2.x Jun 10, 2024
@ChronosSF ChronosSF deleted the rivanova/fix-14198-17.2.x branch June 10, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackofdiamond5 jackofdiamond5 jackofdiamond5 approved these changes

Assignees

@Zneeky Zneeky

Labels

simple-combo version: 17.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simple Combo cannot submit form via ngSubmit

4 participants

@RivaIvanova @jackofdiamond5 @ChronosSF @Zneeky