Skip to content

fix(simple-combo): prevent group header selection on Enter key press - 17.2.x #14432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 23, 2024
Merged

fix(simple-combo): prevent group header selection on Enter key press - 17.2.x #14432

merged 6 commits into from
Jul 23, 2024

Conversation

@georgianastasov
Copy link
Contributor

Closes #14352

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@georgianastasov georgianastasov linked an issue Jun 25, 2024 that may be closed by this pull request
Simple Combo tries to set an item's header as selection target #14352
Closed
@kacheshmarova kacheshmarova requested a review from Zneeky July 23, 2024 07:03
@Zneeky Zneeky added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 23, 2024
@Lipata Lipata merged commit 83bc2a8 into 17.2.x Jul 23, 2024
@Lipata Lipata deleted the ganastasov/fix-14352-17.2.x branch July 23, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackofdiamond5 jackofdiamond5 jackofdiamond5 approved these changes

@Zneeky Zneeky Awaiting requested review from Zneeky

Assignees

No one assigned

Labels

simple-combo version: 17.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simple Combo tries to set an item's header as selection target

6 participants

@georgianastasov @jackofdiamond5 @Lipata @Zneeky @ddaribo @kacheshmarova