Skip to content

fix(advance-filtering): handle error when columns are dynamically changed - 17.2.x #14527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 29, 2024
Merged

fix(advance-filtering): handle error when columns are dynamically changed - 17.2.x #14527

merged 7 commits into from
Jul 29, 2024

Conversation

georgianastasov
Copy link
Contributor

Closes #14314

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@georgianastasov georgianastasov linked an issue Jul 16, 2024 that may be closed by this pull request
Grid Advanced Filtering throws if grid has recreated its columns colection #14314
Closed
@kacheshmarova kacheshmarova requested a review from Zneeky July 26, 2024 11:00
@Zneeky Zneeky added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 26, 2024
@kacheshmarova kacheshmarova merged commit 884f73f into 17.2.x Jul 29, 2024
@kacheshmarova kacheshmarova deleted the ganastasov/fix-14314-17.2.x branch July 29, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zneeky Zneeky Awaiting requested review from Zneeky

1 more reviewer

@ddincheva ddincheva ddincheva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

grid: advanced-filtering grid version: 17.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Grid Advanced Filtering throws if grid has recreated its columns colection

4 participants

@georgianastasov @ddincheva @kacheshmarova @Zneeky