Skip to content

Conversation

Zneeky
Copy link
Contributor

@Zneeky Zneeky commented Jul 22, 2024

Closes #14521

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Zneeky Zneeky requested a review from gedinakova July 22, 2024 12:25

//Check if the search value input is not undefined
let searchValueInputIsNotUndefined = queryBuilderComponent.searchValueInput ? true : false;
expect(searchValueInputIsNotUndefined).toBeTruthy("Search value for dateTime input is undefined and cannot be focused");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we check for thruthy, we don't need to have a separate variable.

Suggested change
expect(searchValueInputIsNotUndefined).toBeTruthy("Search value for dateTime input is undefined and cannot be focused");
expect(queryBuilderComponent.searchValueInput).toBeTruthy("Search value for dateTime input is undefined and cannot be focused");

tick();
fix.detectChanges();
searchValueInputIsNotUndefined = queryBuilderComponent.searchValueInput ? true : false;
expect(searchValueInputIsNotUndefined).toBeTruthy("Search value input is undefined and cannot be focused");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above!

@Zneeky Zneeky requested a review from gedinakova August 7, 2024 12:59
gedinakova
gedinakova previously approved these changes Aug 7, 2024
@gedinakova gedinakova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 7, 2024
@kacheshmarova kacheshmarova merged commit ce40a5a into 17.2.x Aug 14, 2024
@kacheshmarova kacheshmarova deleted the aahmedov/fix-searchValueInputFocus-14521-17.2.x branch August 14, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

query-builder version: 17.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query builder: error is thrown when editing expression for a 'dateTime' field

3 participants