-
Notifications
You must be signed in to change notification settings - Fork 156
fix(query-builder): Fix for dateTime's searchValueInput focus -17.2.x #14555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kacheshmarova
merged 7 commits into
17.2.x
from
aahmedov/fix-searchValueInputFocus-14521-17.2.x
Aug 14, 2024
Merged
fix(query-builder): Fix for dateTime's searchValueInput focus -17.2.x #14555
kacheshmarova
merged 7 commits into
17.2.x
from
aahmedov/fix-searchValueInputFocus-14521-17.2.x
Aug 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps://github.com/IgniteUI/igniteui-angular into aahmedov/fix-searchValueInputFocus-14521-17.2.x
gedinakova
requested changes
Aug 5, 2024
|
||
//Check if the search value input is not undefined | ||
let searchValueInputIsNotUndefined = queryBuilderComponent.searchValueInput ? true : false; | ||
expect(searchValueInputIsNotUndefined).toBeTruthy("Search value for dateTime input is undefined and cannot be focused"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we check for thruthy, we don't need to have a separate variable.
Suggested change
expect(searchValueInputIsNotUndefined).toBeTruthy("Search value for dateTime input is undefined and cannot be focused"); | |
expect(queryBuilderComponent.searchValueInput).toBeTruthy("Search value for dateTime input is undefined and cannot be focused"); |
tick(); | ||
fix.detectChanges(); | ||
searchValueInputIsNotUndefined = queryBuilderComponent.searchValueInput ? true : false; | ||
expect(searchValueInputIsNotUndefined).toBeTruthy("Search value input is undefined and cannot be focused"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above!
gedinakova
previously approved these changes
Aug 7, 2024
gedinakova
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
query-builder
version: 17.2.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14521
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)