Skip to content

fix(query-builder): prevent aria-hidden error on the edit icon - 17.2.x #14718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 17, 2024
Merged

fix(query-builder): prevent aria-hidden error on the edit icon - 17.2.x #14718

merged 6 commits into from
Sep 17, 2024

Conversation

georgianastasov
Copy link
Contributor

Closes #14650

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@georgianastasov georgianastasov linked an issue Sep 4, 2024 that may be closed by this pull request
Query Builder: "Blocked aria-hidden on a <igx-icon> element" error #14650
Closed
@onlyexeption onlyexeption added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Sep 17, 2024
@kacheshmarova kacheshmarova merged commit 0af5e05 into 17.2.x Sep 17, 2024
6 checks passed
@kacheshmarova kacheshmarova deleted the ganastasov/fix-14650-17.2.x branch September 17, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onlyexeption onlyexeption onlyexeption approved these changes

@igdmdimitrov igdmdimitrov Awaiting requested review from igdmdimitrov

Assignees

@onlyexeption onlyexeption

Labels

query-builder version: 17.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Query Builder: "Blocked aria-hidden on a <igx-icon> element" error

3 participants

@georgianastasov @onlyexeption @kacheshmarova