Skip to content

refactor(combo): only handle selection set in id setter - 18.2.x #14964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2024
Merged

refactor(combo): only handle selection set in id setter - 18.2.x #14964

merged 3 commits into from
Nov 5, 2024

Conversation

ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Oct 28, 2024

Closes #14943

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddaribo ddaribo linked an issue Oct 28, 2024 that may be closed by this pull request
IgxComboBaseDirective: Refactor combo id setter #14943
Closed
@ddaribo ddaribo requested a review from IvayloG October 28, 2024 10:37
@Zneeky Zneeky added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 4, 2024
@kacheshmarova kacheshmarova merged commit eca1c18 into 18.2.x Nov 5, 2024
5 checks passed
@kacheshmarova kacheshmarova deleted the bpachilova/14943-combo-id-setter-refactor-18.2.x branch November 5, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvayloG IvayloG IvayloG approved these changes

Assignees

No one assigned

Labels

combo version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IgxComboBaseDirective: Refactor combo id setter

4 participants

@ddaribo @IvayloG @kacheshmarova @Zneeky