Skip to content

Conversation

simeonoff
Copy link
Collaborator

Closes #15021

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff
Copy link
Collaborator Author

@desig9stein Please, also validate all themes look and work correctly, not just indigo.

@dobromirts
Copy link
Contributor

dobromirts commented Nov 15, 2024

The issue persists with that fix. Should we consider using a similar approach from input-group.component? I tested it, and it seems to work well in my opinion.
image and the result is as expected in AB -
image
image

@simeonoff
Copy link
Collaborator Author

@dobromirts Interesting, it works in the dev demos, perhaps something else is triggering change detection there. Will update it as you suggest and push soon.

@simeonoff
Copy link
Collaborator Author

@dobromirts Can you validate the implementation again?

@dobromirts
Copy link
Contributor

@dobromirts Can you validate the implementation again?

@simeonoff Thank you! Everything is working perfectly.

@dobromirts dobromirts added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 15, 2024
@simeonoff simeonoff merged commit e10c6fd into 18.2.x Nov 18, 2024
5 checks passed
@simeonoff simeonoff deleted the simeonoff/fix-15021-18.2.x branch November 18, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checkbox ✨ themes version: 18.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkbox SVG icon displays incorrectly in applications with multiple themes

3 participants