fix(*): icon service doesn't work with scoped themes #15150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonoff
added
input
checkbox
🖼️ icon
❌ status: awaiting-test
simeonoff
changed the title
dobromirts
added
✅ status: verified
damyanpetev
reviewed
Dec 9, 2024
projects/igniteui-angular/src/lib/checkbox/checkbox.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
previously approved these changes
Dec 9, 2024
damyanpetev
reviewed
Dec 9, 2024
projects/igniteui-angular/src/lib/checkbox/checkbox.component.ts
Outdated
Show resolved
Hide resolved
| public subject: BehaviorSubject<IgxTheme>; | ||
|
|
||
| constructor(private t?: IgxTheme) { | ||
| const globalTheme = globalThis.window |
There was a problem hiding this comment.
And I think I preferred this more on the root factory level or was this intentional for a sneaky auto-init on a scoped bit of the DOM? I guess that could be useful, just figured the main use would be to always set something anyway which would make the computed styles call redundant.
There was a problem hiding this comment.
The sneaky thing this allows me to do is to initialize a ThemeToken without passing a theme to the constructor in the root factory, making the preferToken getter return false when no theme is passed to the factory.
damyanpetev
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15094
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)