Skip to content

fix(Highlight): Check if the highlight group exists before activation. #15764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

fix(Highlight): Check if the highlight group exists before activation. #15764

merged 2 commits into from
May 2, 2025

Conversation

gedinakova
Copy link
Contributor

Closes #15735

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@gedinakova gedinakova added ❌ status: awaiting-test PRs awaiting manual verification text-highlight labels Apr 29, 2025
@gedinakova gedinakova requested a review from igdmdimitrov April 29, 2025 08:35
@gedinakova gedinakova requested a review from teodosiah April 29, 2025 08:38
@gedinakova gedinakova changed the title test(Highlight): Adding a test for activating non-existent group. test(Highlight): Check if the highlight group exists before activation. Apr 29, 2025
@gedinakova gedinakova changed the title test(Highlight): Check if the highlight group exists before activation. fix(Highlight): Check if the highlight group exists before activation. Apr 29, 2025
@gedinakova gedinakova removed the ❌ status: awaiting-test PRs awaiting manual verification label May 2, 2025
@gedinakova gedinakova merged commit 33d7052 into 18.2.x May 2, 2025
7 checks passed
@gedinakova gedinakova deleted the gedinakova/fix-activate-highlight-15735-18.2 branch May 2, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igdmdimitrov igdmdimitrov igdmdimitrov approved these changes

@teodosiah teodosiah teodosiah approved these changes

Assignees

No one assigned

Labels

text-highlight

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gedinakova @igdmdimitrov @teodosiah