-
Notifications
You must be signed in to change notification settings - Fork 30
Fix for issues #187 and #146 #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MayaKirova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should also be applied to the igGridComponent and for other components that have two-way databinding (igCombo, igTree).
|
Two-way databinding tests are failing. Probably because the return condition is wrong. We should return if the data source is not array. If it is the two-way databinding logic should execute as before. |
|
@tbelcheva Can you include some tests for this scenario? |
|
@tbelcheva |
|
@tbelcheva Please use https://www.npmjs.com/package/jquery-mockjax instead of bower |
| public opts2: any; | ||
| public opts3: any; | ||
| public optsNew:any; | ||
| public opts4: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbelcheva Where do you configure opts4?
| }) | ||
| class TestComponent { | ||
| private opts: any; | ||
| private opts2: any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbelcheva Where do you configure opts2?
Closes #187
Closes #146