feat(grids): add cell merge samples for React #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed the following bugs, but they also appear in Angular:
@IMinchev64 Also the hierarchical grid custom sample does not have child data, I don't know if that's on purpose or not? I'm approving it as the samples work and look like in Angular |
dkamburov
added
status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom cell merging samples for React, where we have a total of 6 new samples - one regular and one with custom merge strategy for grid, h-grid, and t-grid respectively.
Note: Before testing,
igniteui-reactandigniteui-react-gridsversions should be updated to latest once this fix is merged