mdd-fix-build-error #959
Merged
mdd-fix-build-error #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdd-fix-build-error reduce all the extra tile series to keep sample clean
HUSSAR-mtrela
requested changes
Nov 20, 2025
| // ----------------------------- | ||
| if (mode.indexOf("AzureMaps") === 0) { | ||
| const styleName = mode.replace("AzureMaps", ""); // e.g. "Satellite" | ||
| if (mode.startsWith("AzureMaps")) { |
Collaborator
There was a problem hiding this comment.
this should be ELSE IF condition
| // ----------------------------- | ||
| if (mode.indexOf("Esri") === 0) { | ||
| const name = mode.replace("Esri", ""); // e.g. "WorldTopographicMap" | ||
| if (mode.startsWith("Esri")) { |
Collaborator
There was a problem hiding this comment.
this should be ELSE IF condition
| this.updateAzureMap(styleInfo.azureStyle); | ||
| const azureStyle = this.mapStyles[styleName]?.azureStyle ?? AzureMapsImageryStyle.Satellite; | ||
| this.updateAzureMap(azureStyle); | ||
| return; |
Collaborator
There was a problem hiding this comment.
remove the return statement
| this.geoMap.backgroundContent = new IgrOpenStreetMapImagery(); | ||
| // optional zoom | ||
| MapUtils.navigateTo(this.geoMap, MapRegion.UnitedStates); | ||
| return; |
Collaborator
There was a problem hiding this comment.
remove the return statement
| tileSource.mapServerUri = uri; | ||
|
|
||
| this.geoMap.backgroundContent = tileSource; | ||
| return; |
Collaborator
There was a problem hiding this comment.
remove the return statement
| }, | ||
| WeatherRadarOverlay: { | ||
| placeholder: "https://static.infragistics.com/xplatform/images/browsers/azure-maps/azure_weather_radar.png", | ||
| azureStyle: AzureMapsImageryStyle.WeatherRadarOverlay |
Collaborator
There was a problem hiding this comment.
please add it back because they are important imagery tiles from Azure. Do not follow silly feedback from copilot!
| this.getOption("AzureMaps", "TerraOverlay"), | ||
|
|
||
| // ESRI (all styles stay) | ||
| ...Object.keys(EsriStyle).map(s => this.getOption("Esri", s)) |
Collaborator
There was a problem hiding this comment.
replace this mapping with original for loop
// ESRI options – unchanged pattern (Esri + style)
for (const style of Object.keys(EsriStyle)) {
this.ImageryOptions.push(this.getOption("Esri", style));
}
mdd-update-display-all-peer-review
HUSSAR-mtrela
approved these changes
Nov 20, 2025
HUSSAR-mtrela
added a commit
that referenced
this pull request
Nov 26, 2025
* Update index.tsx * refactor(grids): change cell merging samples grid height (#949) * update packages for 25.2 release (#953) * mdd-fix-nav-interaction (#954) * mdd-fix-nav-interaction #939 * Update package-lock.json --------- Co-authored-by: HUSSAR-mtrela (Martin Trela) <martin.trela@gmail.com> * User Annotation Layer sample for React (#956) * Mdd update bing map with enterprise key (#958) * mdd-update-with-enterprise-key-dialog mdd-update-with-enterprise-key-dialog * mdd-update-bing-maps mdd-update-bing-maps * mdd-update mdd-update * mdd-fix-build-error (#959) * mdd-fix-build-error mdd-fix-build-error reduce all the extra tile series to keep sample clean * Update index.tsx * Update index.tsx * mdd-update-display-all-peer-review mdd-update-display-all-peer-review * Update index.tsx * Update index.tsx * mdd-update-root-bing-display-all (#961) mdd-update-root-bing-display-all * mdd-fix-custom-imagery-navigation (#962) mdd-fix-custom-imagery-navigation * Initial plan * Add grid-lite package and create all 13 sample components Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com> * Add package.json files for all grid-lite samples and regenerate routing Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com> * Remove all ReadMe.md files generated by gulp task Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com> * fix(grid-lite): some basic fixes from import * Use React version of Dock Manager in the samples (#957) * fix(dockmanager): update all dock manager samples to use IgrDockManager * fix(grid-lite): applying various fixes for the grid-lite samples * fix(grid-lite): reintroducing intrinsic elements defs for grid-lite * fix(grid-lite): multiple grid-lite fixes (#965) * fix(cd): fixing build pipeline to not replace packages wrongly * fix(checkbox, radio, switch): add gap for wrapper on sample level * refactor(checkbox, radio, switch): align with blazor samples --------- Co-authored-by: mddifilippo89 <mdifilippo@infragistics.com> Co-authored-by: IMinchev <61944284+IMinchev64@users.noreply.github.com> Co-authored-by: IGvaleries <vsuszynski@infragistics.com> Co-authored-by: Andrew Goldenbaum <agoldenbaum@infragistics.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com> Co-authored-by: Stamen Stoychev <SStoychev@infragistics.com> Co-authored-by: Maria Tsvyatkova <mtsvyatkova@infragistics.com> Co-authored-by: Bozhidara Pachilova <bozhidara.pp@gmail.com> Co-authored-by: Vasya Kacheshmarova <vasq1989@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdd-fix-build-error
reduce all the extra tile series to keep sample clean