Skip to content

Conversation

@paul-griffith
Copy link
Member

Did a bunch of dependency updates at the same time, mostly a YOLO but some quick consideration suggests they should be safe.

I'd love to have you review this @benmusson if you've got time - otherwise I'll merge it in just to get a proper build going and let folks who are asking for it beta test.

@paul-griffith paul-griffith marked this pull request as draft November 6, 2025 19:14
@paul-griffith
Copy link
Member Author

My local environment is very unhappy with me and I haven't been able to un-break it but pushing some test commits to see if it'll build on CI at least

@benmusson
Copy link
Collaborator

benmusson commented Nov 6, 2025

Actually same.
I tried to make a PR last night, ran into the exact same issues with compiling test classes, and gave up.

I couldn't figure out why the test classes are still trying to compile against 2.1.20's standard library.

@paul-griffith
Copy link
Member Author

Yeah... huh. All right, well at least it's not just me. Maybe it's something implicit from kotest...

@paul-griffith paul-griffith marked this pull request as ready for review November 6, 2025 22:03
@paul-griffith
Copy link
Member Author

Well, that's a very unfortunate failure mode.
TODOs for myself:

  1. Use a build convention plugin or whatever they're called to DRY up the toolchain stuff
  2. Update the renovate config file to exclude the test libs from automatic dependency updates as long as we're sticking to Kotlin 1.9 in Ignition (hopefully changing soon 🤞)

@benmusson
Copy link
Collaborator

  1. build convention plugin

I like using a composite build, like includeBuild("build-logic"), instead of relying on buildSrc.

buildSrc = magic
includeBuild("build-logic") = explicit

For a project of this size it doesn't really matter though.

@paul-griffith paul-griffith merged commit 490d113 into IgnitionModuleDevelopmentCommunity:main Nov 10, 2025
1 check passed
@paul-griffith paul-griffith deleted the 8-3-update branch November 10, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants