StringAlgo : Remove join()
#1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkaufman
approved these changes
Jan 13, 2022
johnhaddon
force-pushed
the
removeJoin
branch
from
8074851 to
57ea4c3
Compare
It isn't used in Cortex, we don't know why it is here, and alternatives exist in Boost and Python already.
johnhaddon
force-pushed
the
removeJoin
branch
from
57ea4c3 to
257dbbd
Compare
Member
Author
|
Rebased to fix merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't used in Cortex, we don't know why it is here, and alternatives exist in Boost and Python already. See #1217 (comment).