Update for Maya 2022 #1235
Merged
Update for Maya 2022 #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkaufman
force-pushed
the
maya2022
branch
2 times, most recently
from
f9d372d to
3671f04
Compare
Member
Author
|
This is now rebased so only the Maya commits remain |
andrewkaufman
force-pushed
the
maya2022
branch
from
3671f04 to
d42eebf
Compare
python/IECoreMaya/Menu.py
Outdated
| raise IECore.Exception( "Definition is not a valid IECore.MenuDefinition object." ) | ||
|
|
||
| allPaths = dict(definition.items()).keys() | ||
| allPaths = list(dict(list(definition.items())).keys()) |
bradleyhenke
suggested changes
Feb 15, 2022
| @staticmethod | ||
| def pathValidator(): | ||
| return re.compile( "^(\|?[^\t\n\r\f\v\|]+)+\|?$" ) | ||
| return re.compile( r"^(|?[^\t\n\r\f\v|]+)+\|?$" ) |
Contributor
There was a problem hiding this comment.
I think there is one more backslash that can be removed at the end. re.compile( r"^(|?[^\t\n\r\f\v|]+)+|?$" )
Contributor
There was a problem hiding this comment.
Actually, it is incorrect but for a different reason. The | is a special character so it should either be placed in a character class [|] or use a backslash \|. I think the original expression may have been ill-formed but accepted by python. The first pipe is incorrect, but the last pipe is ok.
python/IECoreMaya/NodeParameter.py
Outdated
| @staticmethod | ||
| def pathValidator(): | ||
| return re.compile( "^(\|?[^\t\n\r\f\v\|]+)+\|?$" ) | ||
| return re.compile( r"^(|?[^\t\n\r\f\v|]+)+\|?$" ) |
bradleyhenke
approved these changes
Feb 15, 2022
bradleyhenke
suggested changes
Feb 15, 2022
Contributor
bradleyhenke
left a comment
bradleyhenke
left a comment
There was a problem hiding this comment.
I double checked, and I don't think the new regex compiles correctly.
This seems a particularly wasteful update... I hope it doesn't impact performance of `next()` noticably
This should be Python 2.7 & 3.7 compatible, but I am not positive I have implemented it correctly...
I believe PyBytes_* was available in Py2 as well
Its possible most of these are unnecessary but Im not sure its worth figuring out which
I have not found a way to run maya without this being true and the code was not compiling for Py3
This was causing some Maya 2022 builtin startup hooks to fail
MenuDefinition.items() returns a list of tuples rather than a generator, so the line can be written slightly less rediculously
andrewkaufman
force-pushed
the
maya2022
branch
from
d42eebf to
9a8db57
Compare
bradleyhenke
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets all tests (and some basic scene shape interactive use) working in Maya 2022 with python 3.
The PR is built on top of #1232, so only the commits with "Maya" in the message need review. I'll rebase after that one is merged.
Also note I have not built this for Maya 2020... at IE we don't have a good way to decouple Cortex 10.4 (
main) dependencies from VFX Platform dependencies. I probably could do it if need be, but the current plan at IE is to upgrade all DCCs at once to the VFX2021-capable-versions and leave gcc6/py2 in the past, so I wasn't sure it was worth the effort....