Build : Use shared lib configuration for all modules #1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
reviewed
Feb 17, 2022
Member
johnhaddon
left a comment
johnhaddon
left a comment
There was a problem hiding this comment.
This Mac failure looks to be the same as the one I fixed in GafferHQ/gaffer#4575.
IMATH_DEPRECATED("use uint64_t")
Could you add the same workaround here?
Comment on lines
3192
to
3194
| LIBS = [ | ||
| "Alembic$ALEMBIC_LIB_SUFFIX", | ||
| ], |
Member
There was a problem hiding this comment.
The branch below this for Alembic < 1.6 will be broken now, because it's not adding AlembicAbcGeom. I don't think we need that branch though, so let's just remove it.
We had been adding this configure trick throughout the SConstruct as needed, and I have now hit a case where I need it for all libaries (to satisfy a boost dependency)
andrewkaufman
force-pushed
the
checkEnv
branch
from
5e62956 to
6f2a86d
Compare
Member
Author
Hopefully solved with 6f2a86d |
andrewkaufman
requested review from
johnhaddon
and removed request for
johnhaddon
johnhaddon
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had been adding this configure trick throughout the SConstruct as needed, and I have now hit a case where I need it for all libraries (to satisfy a boost dependency).