IECoreUSD : Support IECore::Object references when determining primvar type. #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleyhenke
commented
Jun 30, 2022
…r type. `IECore::Object` avoids some data duplication by writing an internal object's data a single time while saving, and then writing a reference path to the data container if other internal objects share the same pointer. One case in which this situation has presented itself is creating a "Pref" primvar to hold the rest positions of a primitive. In the following example, the created "Pref" primitive variable receives a shallow copy of the "P" primitive variable. So, the internal "data" and "indices" members point to the same shared data. Therefore, a reference is created when the primitive object saves itself. ``` box = IECoreScene.MeshPrimitive.createBox( imath.Box3f( imath.V3f(-1), imath.V3f(1) ) ) box['Pref'] = box['P'] ```
bradleyhenke
force-pushed
the
usd_readReferencedPrimvars
branch
from
3ca6102 to
328d591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IECore::Objectavoids some data duplication by writing an internal object'sdata a single time while saving, and then writing a reference path to the data
container if other internal objects share the same pointer.
One case in which this situation has presented itself is creating a "Pref"
primvar to hold the rest positions of a primitive. In the following example,
the created "Pref" primitive variable receives a shallow copy of the "P"
primitive variable. So, the internal "data" and "indices" members point
to the same shared data. Therefore, a reference is created when the primitive
object saves itself.
Related Issues
Dependencies
Breaking Changes
Checklist