Mac CI #1445
Merged
Mac CI #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 15's new linker now complains when asked to link to the same library multiple times. I've removed the duplicates from the modules required to build a regular Cortex release, though I haven't touched the DCC specific modules. If the existing duplicate library specification turns out to be necessary for other platforms, we could alternately disable the linker warning here with `-no_warn_duplicate_libraries`. The new linker also complains that the `-single_module` flag is obsolete. `-single_module` became the default behaviour way back in OSX 10.4, so we should be fairly safe to remove it here. Disabling FMA via `--ffp-contract=off` fixes a test failure with `MeshPrimitiveEvaluator.pointAtUV()` returning an incorrect value in `TestMeshPrimitive.testPlane()`. Curiously, even with `--ffp-contract=off`, this test still fails when run on a virtualized instance of macOS. GitHub's macOS runners are vitualized, so we'll end up skipping this test when we enable macOS CI...
These builds lack signing and notarization and are published chiefly for our own use. Making the build artifacts available, even in their current state, paves the way towards re-establishing Gaffer CI runs on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the minor adjustments necessary to get Cortex building with modern Xcode and reinstate macOS CI jobs, though only on arm64. I've tested a range of Xcode versions and have had success building locally with Xcode 14.3.1, 15.3.0, and 16.1.0, and with Xcode 15.4.0 on GitHub's
macos-14runner image.While we are publishing build artifacts from the macos-arm64 CI runs, these builds lack signing and notarization so are published chiefly for our own use. Making these build artifacts available, even in their current state, paves the way towards re-establishing Gaffer CI runs on macOS.