Skip to content
This repository was archived by the owner on Aug 6, 2024. It is now read-only.

Conversation

@castdrian
Copy link
Collaborator

this pr closes #36 and also closes #56
furthermore it fixes an oversight that caused the intent filters in the android manifest to be malformed, and thus makes the share-to-app capabilities work

it also refactors the project to use typescript and cleans up most of the project structure.
Cleaning up more stuff will follow in separate pr's which address #35 and #55

@castdrian castdrian requested a review from thehairy February 3, 2023 15:24
@thehairy thehairy merged commit 84897dd into imageingapp:main Feb 3, 2023
@castdrian castdrian deleted the feat-tsx branch February 3, 2023 20:58
@tristancamejo
Copy link
Contributor

oh.. just wow.. 🤩
may have to contribute now 👀

@castdrian
Copy link
Collaborator Author

ya, the trick is to just do the work yourself and then he'll be fine with it,

anyway what would be something useful that I don't plan on doing myself anytime this week is to fix the workflow situation, one thing that just straight up doesn't work is to build apk's for every PR since expo requires you to be logged in to run an eas build, so that run condition needs to poof alongside with the also useless workflow that comments a link to the artifact, what also needs to be done, as you pointed out is merging semantic release with the eas release so that the versions are synced, semantic-release has an expo plugin which should make that work, also releaserc needs to be configured to always at least release a minor no matter what commits it finds, because everything else is just annoying

github-actions bot pushed a commit that referenced this pull request Feb 14, 2023
## [0.6.0](0.5.5...0.6.0) (2023-02-14)

### Features

* debug logging ([#66](#66)) ([329f609](329f609))
* initial typescript refactor ([#60](#60)) ([84897dd](84897dd))
* proper release workflow ([#68](#68)) ([a866af0](a866af0))
* release ([cb1de3b](cb1de3b))
* release² ([71d0688](71d0688))
* support gif/video (and webp) ([#64](#64)) ([72ccbb2](72ccbb2))
* update prompt (nice) ([#69](#69)) ([0a88f3b](0a88f3b))

### Bug Fixes

* **meta:** typo `explo` -> `expo` ([#59](#59)) ([ae69ef2](ae69ef2))
* pr build workflow ([#67](#67)) ([0c9b2bf](0c9b2bf))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: allow native backup chore: clean codebase

3 participants