Package fixes #31
Merged
Package fixes #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded `REPO_ROOT` references with `DISTRIBUTED_DOWNLOADER_PATH` for dynamic path management across scripts. Added `initializer` as a callable function in `initialization.py` and exported relevant modules in `__all__`. Updated project scripts in `pyproject.toml` to reflect new module paths.
Updated main script to include a new environment variable for the package path. Expanded documentation in README, including CLI usage and detailed script explanations, and introduced docs/scripts_README.md for supplementary materials.
egrace479
reviewed
May 14, 2025
egrace479
reviewed
May 14, 2025
Updated `MPI_downloader_verifier.py` to include a `recheck` parameter, allowing the rechecking of completed batches. Adjusted related scripts, documentation, and Slurm job handling to support the new flag for better flexibility in verification workflows.
Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com>
egrace479
reviewed
May 20, 2025
egrace479
reviewed
May 20, 2025
Co-authored-by: Elizabeth Campolongo <38985481+egrace479@users.noreply.github.com>
egrace479
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now distributed downloader should be runnable as a package.
Added supplementary documentation for all script files, since they are not packaged with python files and have to be created by the user.