Skip to content

Conversation

@DanielaSchacherer
Copy link
Contributor

  • added qupath export to microscopy ANN notebook
  • updated pathomics README

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 27, 2025

View / edit / reply to this conversation on ReviewNB

fedorov commented on 2025-10-27T18:59:33Z
----------------------------------------------------------------

Prefer to keep the output here


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 27, 2025

View / edit / reply to this conversation on ReviewNB

fedorov commented on 2025-10-27T18:59:34Z
----------------------------------------------------------------

I would strongly prefer to keep the output image panel here!


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 27, 2025

View / edit / reply to this conversation on ReviewNB

fedorov commented on 2025-10-27T18:59:34Z
----------------------------------------------------------------

I had to download that image and open in full resolution to see the annotations, since they are in red, and blend with the image. Is it possible to show those in yellow?


@DanielaSchacherer
Copy link
Contributor Author

View / edit / reply to this conversation on ReviewNB

fedorov commented on 2025-10-27T18:59:34Z ----------------------------------------------------------------

I had to download that image and open in full resolution to see the annotations, since they are in red, and blend with the image. Is it possible to show those in yellow?

It is in general possible if you generate annotations yourself. I remember that it was not easily possible in this case (couldn't figure out the reason) and decided that red is not optimal but good enough for the purpose here.
If it's okay with you, I would keep it that way for the sake of time.

@fedorov fedorov merged commit 71d91fc into ImagingDataCommons:master Oct 27, 2025
@fedorov
Copy link
Member

fedorov commented Oct 27, 2025

It is in general possible if you generate annotations yourself. I remember that it was not easily possible in this case (couldn't figure out the reason) and decided that red is not optimal but good enough for the purpose here.
If it's okay with you, I would keep it that way for the sake of time.

I have to say this is really unfortunate. It is hard to see red over a shade of red... But I didn't want to hold this PR for this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants