Skip to content

Correct code in the servo example #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct code in the servo example #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/servo/code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@ let ledc = Ledc::new(peripherals.LEDC);
let mut hstimer0 = ledc.timer::<HighSpeed>(timer::Number::Timer0);
hstimer0
.configure(timer::config::Config {
duty: timer::config::Duty::Duty5Bit,
duty: timer::config::Duty::Duty12Bit,
clock_source: timer::HSClockSource::APBClk,
frequency: Rate::from_khz(24),
frequency: Rate::from_hz(50),
})
.unwrap();

let mut channel0 = ledc.channel(channel::Number::Channel0, &mut servo);
channel0
.configure(channel::config::Config {
timer: &hstimer0,
duty_pct: 10,
duty_pct: 100,
Copy link
Contributor

@guamoko995 guamoko995 Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why edit this?

Copy link
Author

@one-for-all one-for-all Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by setting it to 100, we are saying that we want to control all 100% of the duty cycle.

Copy link
Contributor

@guamoko995 guamoko995 Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by setting it to 100, we are saying that we want to control all 100% of the duty cycle.

It seems to me that this only sets the initial value of the duty cycle.

The issue has already been fixed here: #17

Copy link
Author

@one-for-all one-for-all Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. 👍

pin_config: channel::config::PinConfig::PushPull,
})
.unwrap();
Expand Down Expand Up @@ -129,17 +129,17 @@ fn main() -> ! {
let mut hstimer0 = ledc.timer::<HighSpeed>(timer::Number::Timer0);
hstimer0
.configure(timer::config::Config {
duty: timer::config::Duty::Duty5Bit,
duty: timer::config::Duty::Duty12Bit,
clock_source: timer::HSClockSource::APBClk,
frequency: Rate::from_khz(24),
frequency: Rate::from_hz(50),
})
.unwrap();

let mut channel0 = ledc.channel(channel::Number::Channel0, &mut servo);
channel0
.configure(channel::config::Config {
timer: &hstimer0,
duty_pct: 10,
duty_pct: 100,
pin_config: channel::config::PinConfig::PushPull,
})
.unwrap();
Expand Down