fix(methods): makes haveMany params model and foreignKey required

Author: Walker Leite

src/methods.js

@@ -10,13 +10,9 @@ export function haveMany(relationship, model, foreignKey) {
 
   expect(relObj).to.haveOwnProperty('model');
   expect(relObj.model).to.not.empty;
-  if (model) {
-    expect(relObj.model).to.equal(model);
-  }
+  expect(relObj.model).to.equal(model);
 
   expect(relObj).to.haveOwnProperty('foreignKey');
   expect(relObj.foreignKey).to.not.empty;
-  if (foreignKey) {
-    expect(relObj.foreignKey).to.equal(foreignKey);
-  }
+  expect(relObj.foreignKey).to.equal(foreignKey);
 }

src/methods.spec.js

@@ -66,11 +66,23 @@ describe('haveMany assertion', () => {
     expect(hasMany({ balls: '' }, 'balls')).toThrow();
   });
 
+  it('throws if missing arguments', () => {
+    expect(hasMany(
+      perfectRelMock,
+      'balls',
+      perfectRelMock.balls.model,
+    )).toThrow();
+    expect(hasMany(
+      perfectRelMock,
+      'balls',
+    )).toThrow();
+    expect(hasMany(perfectRelMock)).toThrow();
+    expect(hasMany()).toThrow();
+  });
+
   it('assert haveMany relationship', () => {
     const subj = perfectRelMock;
     const { model, foreignKey } = perfectRelMock.balls;
-    expect(hasMany(subj, 'balls')).not.toThrow();
-    expect(hasMany(subj, 'balls', model)).not.toThrow();
     expect(hasMany(subj, 'balls', model, foreignKey)).not.toThrow();
   });
 });