IND-90 | Implement CI, Update SDK Configuration, and Enhance Factory Logic #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Summary:
This PR focuses on integrating Continuous Integration (CI), improving the SDK configuration for account abstraction, and handling factory contract management more effectively. It includes updating documentation, enhancing the configuration parameters, and refactoring tests to match the new logic.
Key Changes:
CI Integration:
CI.yml) to automatically run tests and compile TypeScript on every push and pull request tomainanddevelopbranches.SDK Enhancements:
ClientConfigto support bothfactoryAddressandfactoryManagerAddress. This ensures flexibility in using pre-deployed factory addresses or fetching them dynamically from afactoryManager.wrapProvidermethod to fetchfactoryAddressfrom thefactoryManagercontract when not directly provided.Documentation Update:
README.mdto reflect the changes in configuration requirements. Now users must provide eitherfactoryAddressorfactoryManagerAddress.Testing Improvements:
factoryAddressdynamically using thefactoryManagerlogic.Testing Instructions:
factoryAddresslogic behaves as expected:factoryAddressis provided, the SDK should use it directly.factoryManagerAddressis provided, it should dynamically fetch thefactoryAddressfrom the contract.