Skip to content

Conversation

@enis-incentiv
Copy link
Collaborator

@enis-incentiv enis-incentiv commented Sep 25, 2024

PR Description:

Summary:
This PR focuses on integrating Continuous Integration (CI), improving the SDK configuration for account abstraction, and handling factory contract management more effectively. It includes updating documentation, enhancing the configuration parameters, and refactoring tests to match the new logic.

Key Changes:

  1. CI Integration:

    • Added a GitHub Actions workflow (CI.yml) to automatically run tests and compile TypeScript on every push and pull request to main and develop branches.
  2. SDK Enhancements:

    • Updated ClientConfig to support both factoryAddress and factoryManagerAddress. This ensures flexibility in using pre-deployed factory addresses or fetching them dynamically from a factoryManager.
    • Updated the SDK’s wrapProvider method to fetch factoryAddress from the factoryManager contract when not directly provided.
  3. Documentation Update:

    • Updated the README.md to reflect the changes in configuration requirements. Now users must provide either factoryAddress or factoryManagerAddress.
    • Added a note explaining the configuration parameters in the high-level provider API section.
  4. Testing Improvements:

    • Updated tests to deploy and manage the factoryAddress dynamically using the factoryManager logic.
    • Refactored test setup to align with the new configuration and API changes.

Testing Instructions:

  • Ensure that the CI passes all steps, including compilation and running tests.
  • Check that the factoryAddress logic behaves as expected:
    • When a factoryAddress is provided, the SDK should use it directly.
    • When only factoryManagerAddress is provided, it should dynamically fetch the factoryAddress from the contract.

@enis-incentiv enis-incentiv force-pushed the IND-90-implement-aa-provider-sdk-support branch from a18fbb7 to 54c69fb Compare September 25, 2024 16:10
@enis-incentiv enis-incentiv changed the title IND-90 | Implement AA Provider/SDK Support IND-90 | Implement CI, Update SDK Configuration, and Enhance Factory Logic Sep 25, 2024
@DrenIncentiv
Copy link
Contributor

Looks great, thanks!

@DrenIncentiv DrenIncentiv merged commit c7c643d into main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants