Skip to content

Conversation

@enis-incentiv
Copy link
Collaborator

PR Description:

Summary:
This PR updates the prepare script in the SDK’s package.json to ensure that dependencies are installed properly when the SDK is added via a Git URL. Previously, the prepare script only ran tsc, but this did not ensure the installation of node_modules in the SDK folder.

Key Changes:

  • Updated the prepare script from "tsc" to "npm install --ignore-scripts && tsc".
    • This change ensures that:
      1. The SDK's dependencies (node_modules) are installed before running the TypeScript compilation (tsc).
      2. The --ignore-scripts flag prevents triggering the prepare script again during dependency installation, avoiding any potential issues.

Impact:

  • The SDK will now correctly install its dependencies and compile TypeScript when installed as a Git URL in another project.
  • This fix ensures that the SDK can be used seamlessly in other projects with both compiled code and its own dependencies properly installed.

@DrenIncentiv DrenIncentiv merged commit 08762ee into main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants