Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

Conversation

@dbluhm
Copy link
Member

@dbluhm dbluhm commented Oct 23, 2023

This corrects some restrictions that were both too loose and too tight. Namely, python version was set to >=3.9, meaning 4 was technically valid. This was corrected to ^3.9. Additionally, I cleaned up some dependency constraints that were no longer needed after this correction, enabling ACA-Py 0.10.4 to be added to the lock.

@dbluhm dbluhm requested a review from TheTechmage October 23, 2023 16:21
@dbluhm dbluhm force-pushed the fix/pyproject-restrictions branch from 3050e11 to 8163675 Compare October 23, 2023 16:23
This corrects some restrictions that were both too loose and too tight.
Namely, python version was set to >=3.9, meaning 4 was technically
valid. This was corrected to ^3.9. Additionally, I cleaned up some
dependency constraints that were lo longer needed after this correction,
enabling ACA-Py 0.10.4 to be added to the lock.

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm force-pushed the fix/pyproject-restrictions branch from 8163675 to f24d2b7 Compare October 23, 2023 16:25
TheTechmage
TheTechmage previously approved these changes Oct 23, 2023
Copy link
Collaborator

@TheTechmage TheTechmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look like the right fixes to make

There should probably be separate project specs for the different images
but this will do.

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm merged commit d48b6f9 into main Oct 23, 2023
@dbluhm dbluhm deleted the fix/pyproject-restrictions branch December 4, 2023 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants