feat: Add Authlib backend and test compatibility with Askar #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
And add a failing test for further debugging Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
|
Figured out what the issue was after much trial and tribulation: there were values that were b64 encoded and the ascii bytes of the encoded value were being used as part of the key derivation process instead of the decoded bytes. Specifically, |
TheTechmage
requested changes
Nov 13, 2023
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Failing at the moment Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Authlib CryptoService backend.
To be perfectly frank, I'm not a fan of Authlib. For the functions we need from it, it is poorly documented and difficult to follow. My main goal in adding this backend is to (1) exercise the dependency inversion by having more than one backend around and (2) diagnose and debug compatibility issues we're seeing between this library and didcomm-python.