refactor: make services more flexible #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By passing in all dependencies to each method that requires it rather than capturing it in the instance state. This should better support more use cases than the previous structure. This is a backwards compatible change; the more flexible services are wrapped by the `DIDCommMessaging` class to behave exactly the same way as before. To use the new, more flexible services, use `DIDCommMessagingService` class. Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
mepeltier
approved these changes
Apr 19, 2024
TheTechmage
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing in all dependencies to each method that requires it rather than capturing it in the instance state. This should better support more use cases than the previous structure.
This is a backwards compatible change; the more flexible services are wrapped by the
DIDCommMessagingclass to behave exactly the same way as before. To use the new, more flexible services, useDIDCommMessagingServiceclass.