Skip to content

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented May 23, 2024

This PR adds a legacy implementation of DIDComm v1 to the library. This is handy in cases where you are implementing support for both DIDComm v1 and v2. While it is possible to use this now, it should be noted that the legacy implementation is not as polished or easy to use as the v2 implementation. In other words, it will require pretty in depth knowledge of the implementation in order to use it.

We may provide more convenient wrappers around this core functionality in the future.

This implementation requires the legacy extra to be installed.

dbluhm added 3 commits May 23, 2024 12:09
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm requested review from TheTechmage and mepeltier May 23, 2024 16:26
Copy link
Contributor

@mepeltier mepeltier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mepeltier mepeltier merged commit b081958 into main May 23, 2024
@dbluhm dbluhm deleted the feature/legacy branch May 23, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants