Skip to content

Conversation

@pastap
Copy link
Contributor

@pastap pastap commented Oct 25, 2021

Summary

Including the old changes from this PR when pagination was first added
https://github.com/IndicoDataSolutions/indico-client-python/pull/90/files
Includes a fix for the doc report pagination - which didn't add the after variable to the query to allow for pagination - after is used to indicate where the next page should start

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Jira story/task is put into PR title
  • Code has been self-reviewed
  • Hard-to-understand areas have been commented
  • Documentation has been updated
  • My changes generate no new warnings
  • Unit tests have been added for base functionality and known edge cases
  • Any dependent changes have been merged and published in downstream modules

@pastap pastap requested a review from goatrocks October 25, 2021 16:54
Copy link
Contributor

@goatrocks goatrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you

@goatrocks goatrocks merged commit 2e5b027 into master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants