src/corelibs/tone: Modified frequency for XMC. #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
dineshgit411
requested review from
LinjingZhang,
jaenrig-ifx and
ramya-subramanyam
jaenrig-ifx
approved these changes
Sep 4, 2025
Member
jaenrig-ifx
left a comment
jaenrig-ifx
left a comment
There was a problem hiding this comment.
When some of these parameters are recurrently reused across tests, maybe we can define them once as macros (conditionally) at the beginning of the file and avoid excessive repetition of some of the #ifdef blocks in each of the tests.
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Revert back tone implementation in XMC from PWM method to toggle method due to lack of PWM pins.
Related Issue
Context
Modified Frequencies in tone test case and tested in XMC4700 board