src/corelibs/digitalio: Modified testcase runner. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshgit411
requested review from
IFX-Anusha,
LinjingZhang,
jaenrig-ifx and
ramya-subramanyam
jaenrig-ifx
reviewed
Sep 10, 2025
|
|
||
| TEST_ASSERT_EQUAL_MESSAGE(LOW, digitalRead(TEST_PIN_DIGITAL_IO_INPUT), "Input Pin should be set to LOW initially"); | ||
|
|
||
| //Due to few XMC digital I/O s connected in level translator its always in HIGH state even if we set PULLDOWN, so could not able to test this condition. |
Member
There was a problem hiding this comment.
This comment is more helpful if next to the conditional #ifndef block...., or?
LinjingZhang
requested changes
Sep 10, 2025
Collaborator
LinjingZhang
left a comment
LinjingZhang
left a comment
There was a problem hiding this comment.
We have to check again if the board type affect the test result.
In HiL, pull down is actually passing and pull up failed: https://github.com/Infineon/XMC-for-Arduino/actions/runs/17151188928/job/48663850307
The Board used in HiL has microSD and Ethernet - please check the one you used is identical.
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
dineshgit411
force-pushed
the
XMC-digitalio-fix
branch
from
f550ae2 to
ced6f2e
Compare
LinjingZhang
approved these changes
Sep 11, 2025
Collaborator
LinjingZhang
left a comment
LinjingZhang
left a comment
There was a problem hiding this comment.
test pass. I will approve!
Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Modified digitalio implementation for recent test case update, due to different type of board variants we met failing the test case. Now we decided to use 4700 Relax Kit.
INPUT_PULLUP test case need small delay to stabilize the voltage in floating state so added.
Related Issue
Invalid pin and pinmode got hanged in test case, so left those test case.
Context
tested with XMC4700 Relax kit Board Shorted INPUT and OUTPUT with Jumper wire