issue/581 - 添加python的linear的实现,接口和测试 #582
Open
+287
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengcheng888
changed the title
pengcheng888
force-pushed
the
issue/581
branch
from
c43faf3 to
7a19fff
Compare
Ceng23333
reviewed
Nov 14, 2025
src/infinicore/ops/linear/linear.cc
Outdated
|
|
||
| Tensor linear(Tensor input, | ||
| Tensor weight, | ||
| pybind11::object bias) { |
Contributor
Author
There was a problem hiding this comment.
Pyorch的接口中， bias可能是None 或 Tensor。 为了向pytorch那样，只使用一个函数处理这两种情况。 就使用object类作为类型了， 再c++中判断是否是None，再转换
Contributor
Author
There was a problem hiding this comment.
回来修改： 从include中移除 pybind的头文件， 再加一个中间的函数处理none的情况
Collaborator
|
可以把nn::module::Linear里的compute_linear替换成这个实现 |
pengcheng888
force-pushed
the
issue/581
branch
from
7a19fff to
fc2f2a0
Compare
PanZezhong1725
requested changes
Nov 17, 2025
test/infinicore/ops/linear.py
Outdated
|
|
||
| def torch_operator(self, input, weight, bias, out=None, **kwargs): | ||
| """PyTorch linear implementation""" | ||
| result = torch.nn.functional.linear(input, weight, bias) |
|
|
||
| namespace py = pybind11; | ||
|
|
||
| namespace infinicore::ops::linear { |
pengcheng888
force-pushed
the
issue/581
branch
2 times, most recently
from
e6b047c to
d11927b
Compare
pengcheng888
force-pushed
the
issue/581
branch
from
d11927b to
9dbf020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目标版本
main
功能描述
添加linear的实现,接口和测试
gpu测试
cpu测试
