refactor: Remove seasonality detection and add comprehensive test script #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the previously implemented seasonality detection feature and introduces a new comprehensive test script.
Changes include:
- Removed the `_detect_seasonality` method from `pyautoplot/__init__.py`.
- Removed the "Seasonality" output from the time-series analysis in `_generate_analysis`.
- Removed `statsmodels` from dependencies in `setup.py` and from imports in `pyautoplot/__init__.py`.
- Replaced the existing `test.py` with a new script that:
- Creates a `test_output` directory for plot outputs.
- Uses `energy_consumption_dataset.csv` (with a dummy fallback).
- Demonstrates `AutoPlot` initialization.
- Runs `auto_plot()` with default and custom configurations.
- Runs manual `plot()` for scatter, distribution, boxplot, and bar types.
- Shows usage of the `customize()` method.
- Includes a test with a small, inline dataset.
- Saves all generated plots for visual inspection.
- Verified that `README.md` did not require changes as the seasonality feature was not explicitly documented there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the previously implemented seasonality detection feature and introduces a new comprehensive test script.
Changes include:
_detect_seasonalitymethod frompyautoplot/__init__.py._generate_analysis.statsmodelsfrom dependencies insetup.pyand from imports inpyautoplot/__init__.py.test.pywith a new script that:test_outputdirectory for plot outputs.energy_consumption_dataset.csv(with a dummy fallback).AutoPlotinitialization.auto_plot()with default and custom configurations.plot()for scatter, distribution, boxplot, and bar types.customize()method.README.mddid not require changes as the seasonality feature was not explicitly documented there.