Skip to content

Commit 03f7769

Browse files
committed
refactor: pass through plugin instead of app for getBases
Pass through the plugin as a parameter instead of the app. This is so that the bases can be saved to the plugin in memory.
1 parent be30900 commit 03f7769

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

src/listeners/bases.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { App, TFile, parseYaml } from "obsidian";
22
import { Base } from "../types";
3+
import ThumbnailPlugin from "main";
34

45
type Filter =
56
| undefined
@@ -13,16 +14,17 @@ interface Schema {
1314
views?: Array<{ filters: Filter;[key: string]: unknown }>;
1415
}
1516

16-
export async function getBases(app: App): Promise<Array<Base>> {
17-
const files = app.vault.getFiles().filter((v) => v.extension === "base");
17+
export async function getBases(plugin: ThumbnailPlugin): Promise<Array<Base>> {
18+
const files = plugin.app.vault.getFiles().filter((v) => v.extension === "base");
1819
const bases: Array<Base> = [];
1920
for (const file of files) {
2021
bases.push({
2122
path: file.path,
2223
file: file,
23-
content: await app.vault.read(file),
24+
content: await plugin.app.vault.read(file),
2425
});
2526
}
27+
plugin.bases = bases;
2628
return bases;
2729
}
2830

src/main.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Plugin, TFile } from 'obsidian';
2-
import { PluginSettings } from './types';
2+
import { Base, PluginSettings } from './types';
33
import { generate } from "./generator";
44
import { SettingTab } from './settings';
55
import { getBases, getFiles } from './listeners/bases';
@@ -11,11 +11,13 @@ const defaultSettings: PluginSettings = {
1111

1212
export default class ThumbnailPlugin extends Plugin {
1313
settings: PluginSettings;
14+
bases: Base[];
15+
1416
async onload() {
1517
await this.loadSettings();
1618

1719
this.addRibbonIcon("documents", "Create thumbnails", async () => {
18-
let bases = await getBases(this.app);
20+
let bases = await getBases(this);
1921
console.debug(bases);
2022
for (const base of bases) {
2123
console.debug(base);

0 commit comments

Comments
 (0)