PHPC-572: Keep stream context options alive for Manager's lifetime

Author: jmikola

php_phongo.c

@@ -2043,6 +2043,17 @@ bool phongo_manager_init(php_phongo_manager_t *manager, const char *uri_string,
 		return false;
 	}
 
+	/* Keep a reference to driverOptions, since it may be referenced later for
+	 * lazy stream initialization. */
+	if (driverOptions) {
+#if PHP_VERSION_ID >= 70000
+		ZVAL_COPY(&manager->driverOptions, driverOptions);
+#else
+		Z_ADDREF_P(driverOptions);
+		manager->driverOptions = driverOptions;
+#endif
+	}
+
 	return true;
 } /* }}} */
 

php_phongo_structs-5.h

@@ -56,6 +56,7 @@ typedef struct {
 	zend_object              std;
 	mongoc_client_t         *client;
 	char                    *pem_file;
+	zval                    *driverOptions;
 } php_phongo_manager_t;
 
 typedef struct {

php_phongo_structs-7.h

@@ -55,6 +55,7 @@ typedef struct {
 typedef struct {
 	mongoc_client_t         *client;
 	char                    *pem_file;
+	zval                     driverOptions;
 	zend_object              std;
 } php_phongo_manager_t;
 

src/MongoDB/Manager.c

@@ -381,6 +381,14 @@ static void php_phongo_manager_free_object(phongo_free_object_arg *object TSRMLS
 		efree(intern->pem_file);
 	}
 
+#if PHP_VERSION_ID >= 70000
+	zval_ptr_dtor(&intern->driverOptions);
+#else
+	if (intern->driverOptions) {
+		zval_ptr_dtor(&intern->driverOptions);
+	}
+#endif
+
 #if PHP_VERSION_ID < 70000
 	efree(intern);
 #endif

tests/manager/bug0572.phpt

@@ -0,0 +1,32 @@
+--TEST--
+PHPC-572: Ensure stream context does not go out of scope before socket init
+--SKIPIF--
+<?php require __DIR__ . "/../utils/basic-skipif.inc"; NEEDS("STANDALONE_SSL"); ?>
+--FILE--
+<?php
+require_once __DIR__ . "/../utils/basic.inc";
+
+$closure = function() {
+    $context = stream_context_create([
+        'ssl' => [
+            'verify_peer' => false,
+            'verify_peer_name' => false,
+            'allow_self_signed' => true,
+        ],
+    ]);
+    return new MongoDB\Driver\Manager(STANDALONE_SSL, ['ssl' => true], ['context' => $context]);
+};
+
+$manager = $closure();
+$cursor = $manager->executeCommand(DATABASE_NAME, new MongoDB\Driver\Command(['ping' => 1]));
+var_dump($cursor->toArray()[0]);
+
+?>
+===DONE===
+<?php exit(0); ?>
+--EXPECTF--
+object(stdClass)#%d (%d) {
+  ["ok"]=>
+  float(1)
+}
+===DONE===