Translation-ja: Add contributor/ja/02-becoming-a-contributor-article-ja #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging @johtani for potential review? |
johtani
approved these changes
Oct 27, 2020
Collaborator
johtani
left a comment
johtani
left a comment
There was a problem hiding this comment.
Basically LGTM. I left only one small comment :D
|
|
||
| それでは - あなたはチームの製品に、新しい機能を実装しています。 | ||
| この機能を動作させるためには、いくつかの機能が必要です。 | ||
| 実装に直ぐに加わる代わりに、少し落ち着いて考えます：この機能は一般的な課題なのだろうか？ |
Collaborator
There was a problem hiding this comment.
「実装に直ぐに取り掛かる代わりに」はどうでしょう？
Contributor
Author
There was a problem hiding this comment.
ありがとうございます。提案いただいた修正を取り込みました。
Contributor
|
Awesome! @johtani if it looks good to you then I am happy to merge. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a translation for 02-becoming-a-contributor-article.