Add article contributors in learning path markdown metadata #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice! What does it look like? |
Collaborator
Author
Hey @rrrutledge, see screenshots on linked PR InnerSourceCommons/innersourcecommons.org#222. |
rrrutledge
reviewed
Nov 5, 2020
scripts/get_contributors.js
Outdated
| throw Error('This script needs updating to handle >100 commits') | ||
| } | ||
|
|
||
| return [...new Set(history.nodes.map(node => node.author.name))] |
Contributor
There was a problem hiding this comment.
Does this response have the web URL of the author's profile page as well? I think it would be nice to pass that through so that their name can be rendered as a link back to their GitHub profile.
Collaborator
Author
There was a problem hiding this comment.
Good idea, updated this PR and also InnerSourceCommons/innersourcecommons.org#222.
Collaborator
Author
|
Merge conflicts resolved - I will merge this tomorrow (Friday) if no one has any objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets contributors per article and adds them to the metadata used on the website.
Note that the GitHub data isn't perfect, so we get situations where e.g. the German introduction articles were moved, losing the contributor metadata before the move.